feat: add discrete saving to callback structs #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/callback-save
branch
2 times, most recently
from
d0d86c3 to
4d0ac40
Compare
This was referenced Aug 22, 2025
AayushSabharwal
changed the title
AayushSabharwal
force-pushed
the
as/callback-save
branch
5 times, most recently
from
78fae9a to
5014cba
Compare
This was referenced Aug 25, 2025
Merged
AayushSabharwal
changed the title
| get the values to save. If it returns `nothing`, then the save does not happen. | ||
| """ | ||
| function save_discretes!(integ::DEIntegrator, timeseries_idx) | ||
| function save_discretes!(integ::DEIntegrator, timeseries_idx; skip_duplicates = false) |
Member
There was a problem hiding this comment.
what is this undocumented arg?
Member
Author
There was a problem hiding this comment.
Added a docstring. It's to avoid saving variables twice.
AayushSabharwal
force-pushed
the
as/callback-save
branch
from
5014cba to
be03c50
Compare
src/callbacks.jl
Outdated
| # Extended help | ||
| - `discrete_save_idxs`: An iterable of timeseries indexes to save after the callback triggers. MTK-only |
Member
Author
There was a problem hiding this comment.
The index used to refer to a clock partition. This is terminology SII uses.
Member
Author
There was a problem hiding this comment.
Renamed to saved_clock_partitions
AayushSabharwal
force-pushed
the
as/callback-save
branch
from
be03c50 to
30561e7
Compare
Member
|
The test failure on Core seems related. |
AayushSabharwal
force-pushed
the
as/callback-save
branch
from
30561e7 to
2e4aaad
Compare
Member
Author
|
That was a funny accident - I used find-and-replace to rename the type parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.